Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to use multiple tags when querying for services #212

Closed
jebentier opened this issue Jan 21, 2021 · 2 comments · Fixed by #213
Closed

Unable to use multiple tags when querying for services #212

jebentier opened this issue Jan 21, 2021 · 2 comments · Fixed by #213
Labels
enhancement help wanted

Comments

@jebentier
Copy link
Contributor

Right now for example Diplomat::Health.service allows the passing of a tag option to filter the results from Consul. But this only accepts a single string today. It would be nice to be able to pass this an array of strings so that you can pass multiple tags that are all required to exist on the registered service for it to be returned by Consul. Consul's API supports this through specifying the tag query parameter multiple times.

If others feel like this is worth while, I'd be more than happy to put together a PR for the enhancement.
@pierresouchay
Copy link
Member

@jebentier Sure, feel free to submit a PR!

@jebentier jebentier mentioned this issue Jan 22, 2021
Merged
@jebentier
Copy link
Contributor Author

@pierresouchay That is great to hear, I've gone ahead and created PR #213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add multiple tag suppport
2 participants
@jebentier @pierresouchay