Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple tag suppport #213

Merged
merged 3 commits into from
Jan 25, 2021
Merged

Add multiple tag suppport #213

merged 3 commits into from
Jan 25, 2021

Conversation

jebentier
Copy link
Contributor

This is doing a couple things to bring this gem more in alignment with the expectations of the Consul API:

  1. It is generalizing the Faraday connection to always use FlatParamsEncoder. This is because Consul's API has already taken the stance that they do not expect multiple params to be specified using [] but instead by simply repeating the same query param multiple times.
  2. Adding support to Diplomat::Health.service for specifying an array of tags when querying for a service's health checks

Fixes #212

@pierresouchay pierresouchay merged commit cff2a8f into WeAreFarmGeek:master Jan 25, 2021
@jebentier jebentier deleted the add_multiple_tag_suppport branch January 25, 2021 17:30
@pierresouchay
Copy link
Member

@jebentier Your Pull request has been merged and published into release 2.4.3

For your info: if you use Consul and needs to generate templates or UIs, you might also have a look at https://github.com/criteo/consul-templaterb/ (which is far more efficient and easy to hack than diplomat if you just need templates)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use multiple tags when querying for services
2 participants