Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/develop #291

Merged
merged 44 commits into from
Feb 20, 2024
Merged

Feature/develop #291

merged 44 commits into from
Feb 20, 2024

Conversation

apricot13
Copy link
Member

@apricot13 apricot13 commented Nov 29, 2023

also includes #270 and #271 and parts of #286

#266 and #256 cant be included yet

  • update the tests to ensure the settings are set when set

image

  • update tooltip previews
image image image

heroku buildpacks:add heroku/nodejs -i 1 --app tpx-outpost-demo-staging

em-cd and others added 30 commits October 10, 2022 11:34
…eport' into feature/rails-6-containerisation
#2 Update to the scss to make themeing more robust
…tion-editor

#3 Adds a wysiwyg editor to the description field for services
Small fix to the full width layout page erroring
…text-fix

Feature/wysiwyg and rich text fix
use puma as webserver

update gemfile.lock to use the correct bundler version

add app.json file

remove windows from gemfile for heroku to stop regenerating it each deploy!
enable in-dyno databases for tests

Update database_cleaner version for tests

allow in-dyno database urls

Update babelconfig for test environment to compile assets

include chrome buildpacks for heroku tests

Update selenium-webdrivers, remove webdrivers gem update chrome binary settings

fix for :options error

add 'test' docker compose file and update chrome settings
@apricot13 apricot13 marked this pull request as ready for review February 20, 2024 11:05
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b701cf8) 78.64% compared to head (81ee706) 54.85%.
Report is 1 commits behind head on develop.

Files Patch % Lines
app/controllers/admin/settings_controller.rb 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop     #291       +/-   ##
============================================
- Coverage    78.64%   54.85%   -23.79%     
============================================
  Files          167      112       -55     
  Lines         3015     2337      -678     
============================================
- Hits          2371     1282     -1089     
- Misses         644     1055      +411     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apricot13
Copy link
Member Author

fyi: Code coverage drop is related to #271

@apricot13 apricot13 merged commit 33315af into develop Feb 20, 2024
3 of 4 checks passed
This was referenced Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants