Celeba and Label-dependent transformations. #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmke8
changed the title
|
Tests pass! |
olliethomas
reviewed
Jan 10, 2020
tests/vision_test.py
Outdated
| greyscale=False, | ||
| ) | ||
|
|
||
| augmented_data = colorizer(data, labels) |
There was a problem hiding this comment.
are there any assertions that you can make about the augmented data?
There was a problem hiding this comment.
Such assertions would be easy enough to devise despite my earlier grounsing about it. To check its basic functionality, for instance, simply apply the transform with scale 0 to matrices of zeroes, one for each colour and check for correspondence with the predefined mean rgb values.
|
Should we get this merged in? |
|
If it's up to your standards, absolutely. |
|
@thomkeh ? |
|
Yeah, maybe put a to-do in the test. |
tmke8
commented
Jan 14, 2020
Co-Authored-By: thomkeh <7741417+thomkeh@users.noreply.github.com>
|
Sorry, that to-do comment wasn't properly indented. My fault! |
|
It wasn't even a comment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.