Add missing React-related eslint rules #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odididi
force-pushed
the
odididi/update-react-rules
branch
from
4b1a3dc
to
217faad
Compare
d-eisenga
reviewed
Jul 19, 2021
This rule, when enabled, prevents using React's string interpolation,
for example:
<a>
Hello {thing}!
</a>
Would have to be changed to
<a>
{`Hello ${thing}!`}
</a>
And while the rule itself is useful, its primary use is already covered
by jsx-closing-bracket-location.
This commit disables the rule to allow string interpolation, and we'll
rely on jsx-closing-bracket-location to prevent multiple opening or
closing tags on the same line.
Avaq
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.