Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Sample dependencies are being added to the root package.json #100

Open
renanborgez opened this issue Oct 2, 2019 · 0 comments
Open

Sample dependencies are being added to the root package.json #100

renanborgez opened this issue Oct 2, 2019 · 0 comments
Assignees

Comments

@renanborgez
Copy link
Contributor

renanborgez commented Oct 2, 2019

Describe the bug
Some dependencies used in samples are being packaged alongside of webpacker because it is listed in the root package.json and it should be installed only in the respective sample package.json

Expected behavior
Sample dependencies should only be listed in sample package.json's

To Do
Would be nice to make a general cleanup in the dependencies, seems that some could be removed because are not being used anymore.

@renanborgez renanborgez added the bug label Oct 2, 2019
@renanborgez renanborgez self-assigned this Oct 2, 2019
@renanborgez renanborgez changed the title Sample dependencies are being add in the root package.json Sample dependencies are being added to the root package.json Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant