Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove settings for #pll_switcher #11

Closed
ocean90 opened this issue Oct 18, 2018 · 4 comments
Closed

Remove settings for #pll_switcher #11

ocean90 opened this issue Oct 18, 2018 · 4 comments
Milestone

Comments

@ocean90
Copy link
Member

ocean90 commented Oct 18, 2018

case '#pll_switcher':
$menu_item->type_label = __( 'Language Switcher', 'menu-item-types' );
break;

@ocean90 ocean90 added this to the 2.0 milestone Oct 18, 2018
@grappler
Copy link
Contributor

What is the reason for this?

@ocean90
Copy link
Member Author

ocean90 commented Oct 19, 2018

Unless I'm missing something, the Language Switcher type is not a custom type provided by this plugin.

@grappler
Copy link
Contributor

grappler commented Oct 19, 2018

Ok, that makes sense. It was not clear to me as the issue and the commit only stated what the change is and not why it being done.

In that case we should either continue to have this change in the Prohelvetia Theme or contribute it upstream to Polylang.

@grappler
Copy link
Contributor

I have created an issue with Polylang polylang/polylang#307

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants