-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exit Code and Status #50
Comments
The action should have created two additional checks for you, named |
@samuelmeuli thanks for the answer. How can I combine results of Currently I have a workflow similar to below. (Simplified for example purposes) - name: Run linters
uses: samuelmeuli/lint-action@v1
with:
eslint: true
prettier: true
- name: Test
run: jest
- name: Release
if: [SHOULD I ADD SOME CONDITION BASED ON PRETTIER AND ESLINT RESULT ???]
run: npm publish PS: This is Edit2: I just wanted to prevent release on push, if lint or test fails. |
Normally I would use - name: Run linters
uses: samuelmeuli/lint-action@v1
with:
eslint: true
prettier: true
- name: Test
run: jest
- name: Release
needs: [Prettier, ESLint]
run: npm publish |
@samuelmeuli could you please elaborate? |
I looked through the source code and realized that the ESLint and Prettier checks that are created here are actual github Checks. I have no idea if these can be depended on to prevent a job like "Release" from being run. |
Most probably, I'm missing something, but ESLint and Prettier does not stop workflow and have green checkmark even with errors.
As a result code with lint errors get published.
This is my config:
By the way, this workflow is for
push
event.The text was updated successfully, but these errors were encountered: