Exit Code and Status

[ozum]

Most probably, I'm missing something, but ESLint and Prettier does not stop workflow and have green checkmark even with errors.

As a result code with lint errors get published.

This is my config:

      - name: Run linters
        uses: samuelmeuli/lint-action@v1
        with:
          github_token: ${{ secrets.github_token }}
          eslint: true
          eslint_extensions: js,jsx,ts,tsx,vue
          eslint_args: --max-warnings 0
          prettier: true
          prettier_extensions: json,less,css,md,gql,graphql,html,yaml
          prettier_args: --ignore-path .eslintignore

By the way, this workflow is for push event.

[samuelmeuli]

The action should have created two additional checks for you, named ESLint and Prettier. Details here: #31

[ozum]

@samuelmeuli thanks for the answer. How can I combine results of ESLint and Prettier and conditionally run Release step?

Currently I have a workflow similar to below. (Simplified for example purposes)

  - name: Run linters
    uses: samuelmeuli/lint-action@v1
    with:
      eslint: true
      prettier: true
  - name: Test
    run: jest
  - name: Release
    if: [SHOULD I ADD SOME CONDITION BASED ON PRETTIER AND ESLINT RESULT ???]
    run: npm publish

PS: This is push workflow, not PR

Edit2: I just wanted to prevent release on push, if lint or test fails.

[BraveLilToaster]

Normally I would use needs (see docs) in the workflow, but I am having issues with this as well. Since the checks ESLint and Prettier aren't declared in the workflow I can't use needs here.

 - name: Run linters
    uses: samuelmeuli/lint-action@v1
    with:
      eslint: true
      prettier: true
  - name: Test
    run: jest
  - name: Release
    needs: [Prettier, ESLint]
    run: npm publish

[ozum]

@samuelmeuli could you please elaborate?

[BraveLilToaster]

I looked through the source code and realized that the ESLint and Prettier checks that are created here are actual github Checks. I have no idea if these can be depended on to prevent a job like "Release" from being run.