Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLab: Repository visibility is inverted #217

Closed
ocean90 opened this issue Jun 10, 2021 · 0 comments · Fixed by #216 or #215
Closed

GitLab: Repository visibility is inverted #217

ocean90 opened this issue Jun 10, 2021 · 0 comments · Fixed by #216 or #215
Assignees
@ocean90
Labels
[Type] Bug Bugs and regressions in existing functionality
Milestone
3.2.0

Comments

@ocean90
Copy link
Member

ocean90 commented Jun 10, 2021

Issue Overview
There are two issues:

  • The webhook is using an incorrect value for checking if a project is public or not. Currently any private project will be set to public and and vice versa.
  • The API request in the GitLab repository class is not URL encoding the project thus all projects will be set to private

To Reproduce
Steps to reproduce the behavior:

  1. Create a private GitLab project
  2. Trigger the first webhook
  3. Run wp traduttore project info <project> and notice that "Repository Visibility" prints "public.

Expected behavior
GitLab projects get the the correct visibility assigned
@ocean90 ocean90 added the [Type] Bug Bugs and regressions in existing functionality label Jun 10, 2021
@ocean90 ocean90 added this to the 3.2.0 milestone Jun 10, 2021
@ocean90 ocean90 self-assigned this Jun 10, 2021
This was referenced Jun 10, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocean90 ocean90

Labels
[Type] Bug Bugs and regressions in existing functionality
Projects
None yet
Milestone
3.2.0
1 participant
@ocean90