port to Psych 4 included in Ruby 3.1 #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since I am not sure when, pwstore just completely fails to start in
Debian bookworm:
anarcat@curie:tor-passwords$ ~/src/pwstore/pws update-keyring
Unknown alias: weasel
It turns out this is a failure of the YAML module to load our
configuration file because of aliases:
irb(main):004:0> YAML::load_file("/home/anarcat/.pws.yaml")
/usr/lib/ruby/3.1.0/psych/visitors/to_ruby.rb:430:in `visit_Psych_Nodes_Alias': Unknown alias: weasel (Psych::BadAlias)
The fix seems to be to enable aliases, which is what this project has
done:
sidekiq/sidekiq#5140
Rails seems to have switched to unsafe load, which seems like a bad
idea:
rails/rails#42257
|
A similar change (without the guard for psych version) has been committed some time last year. Is this still needed? |
|
oh, i guess not... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since I am not sure when, pwstore just completely fails to start in Debian bookworm:
It turns out this is a failure of the YAML module to load our configuration file because of aliases:
The fix seems to be to enable aliases, which is what this project has done:
sidekiq/sidekiq#5140
Rails seems to have switched to unsafe load, which seems like a bad idea:
rails/rails#42257