Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings when I compile master #224

Closed
PEZ opened this issue Apr 18, 2021 · 2 comments
Closed

Warnings when I compile master #224

PEZ opened this issue Apr 18, 2021 · 2 comments

Comments

@PEZ
Copy link
Contributor

PEZ commented Apr 18, 2021

Hello,

When I run lein install I get these warnings:

% lein install
OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
Warning: implicit hook found: leiningen.cljsbuild/activate 
Hooks are deprecated and will be removed in a future version.
Compiling ClojureScript...
Compiling ["target/out/tests.js"] from ["src" "test"]...
WARNING: rewrite-clj.zip.whitespace/prepend-space is deprecated at line 106 target/out/rewrite_clj/zip/whitespace.cljc
WARNING: rewrite-clj.zip.whitespace/append-space is deprecated at line 113 target/out/rewrite_clj/zip/whitespace.cljc
WARNING: rewrite-clj.zip.whitespace/prepend-newline is deprecated at line 120 target/out/rewrite_clj/zip/whitespace.cljc
WARNING: rewrite-clj.zip.whitespace/append-newline is deprecated at line 127 target/out/rewrite_clj/zip/whitespace.cljc
WARNING: rewrite-clj.node.protocols/value is deprecated at line 88 target/out/rewrite_clj/zip/base.cljc
WARNING: rewrite-clj.node.protocols/value is deprecated at line 207 target/out/rewrite_clj/node.cljc
WARNING: rewrite-clj.zip.base/value is deprecated at line 253 target/out/rewrite_clj/zip.cljc
WARNING: rewrite-clj.zip.base/->string is deprecated at line 273 target/out/rewrite_clj/zip.cljc
WARNING: rewrite-clj.zip.base/->root-string is deprecated at line 283 target/out/rewrite_clj/zip.cljc
WARNING: rewrite-clj.zip.whitespace/prepend-space is deprecated at line 886 target/out/rewrite_clj/zip.cljc
WARNING: rewrite-clj.zip.whitespace/prepend-space is deprecated at line 887 target/out/rewrite_clj/zip.cljc
WARNING: rewrite-clj.zip.whitespace/append-space is deprecated at line 892 target/out/rewrite_clj/zip.cljc
WARNING: rewrite-clj.zip.whitespace/append-space is deprecated at line 893 target/out/rewrite_clj/zip.cljc
WARNING: rewrite-clj.zip.whitespace/prepend-newline is deprecated at line 898 target/out/rewrite_clj/zip.cljc
WARNING: rewrite-clj.zip.whitespace/prepend-newline is deprecated at line 899 target/out/rewrite_clj/zip.cljc
WARNING: rewrite-clj.zip.whitespace/append-newline is deprecated at line 904 target/out/rewrite_clj/zip.cljc
WARNING: rewrite-clj.zip.whitespace/append-newline is deprecated at line 905 target/out/rewrite_clj/zip.cljc
Successfully compiled ["target/out/tests.js"] in 6.12 seconds.
Created /Users/pez/Projects/cljfmt/cljfmt/target/cljfmt-0.7.0-pez-testing.jar
Wrote /Users/pez/Projects/cljfmt/cljfmt/pom.xml
Installed jar and pom into local repo.

I also get errors trying to use this in my shadow-cljs build, but I'll file a separate issue about that, b/c yeah separate issue maybe. 😄

Ping @lread .

@weavejester
Copy link
Owner

These warnings aren't caused by the cljfmt codebase, but in rewrite-clj, so I'll close this.

@lread
Copy link
Contributor

lread commented Apr 28, 2021

@PEZ, feel free to re-raise this one as-is over at rewrite-clj if you like.

I can see that the deprecation warnings would be annoying/confusing/misleading.

FWIW, I typically turn deprecation warnings off for cljs builds and instead rely on clj-kondo, which offers finer control over which deprecation warnings are raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants