Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the refmap construct #64

Closed
wants to merge 1 commit into from
Closed

Conversation

clyfe
Copy link

@clyfe clyfe commented Dec 28, 2019

The refmap construct is similar to refset, but resolves to a map from
keys to resolved refs, rather than a set of refs; it is useful when the
keys are meaningful to the logic beyond just being a slot in the config
map, and are required in further logic.

Resolves #63

@weavejester
Copy link
Owner

Please ensure the code and commit message adheres to the contributing guidelines.

@clyfe clyfe changed the title #63 Added refmap construct Add the refmap construct Dec 29, 2019
@weavejester
Copy link
Owner

Thanks. Can you separate out the introduction of the additional protocol method into its own PR? I'm not sure about #ig/refmap, but I'm more willing to accept an extra protocol method to allow that functionality to be added by users. I think I'd also want to call the extra method ref-resolve rather than resolve-ref.

@clyfe
Copy link
Author

clyfe commented Dec 31, 2019

Rebased on feature/65-reflike-resolve

The refmap construct is similar to refset, but resolves to a map from
keys to resolved refs, rather than a set of refs; it is useful when the
keys are meaningful to the logic beyond just being a slot in the config
map, and are required in further logic.

Resolves weavejester#63
@clyfe
Copy link
Author

clyfe commented Jan 10, 2020

@weavejester Can you approve or reject this one? Or are you still uncertain?

@weavejester
Copy link
Owner

My thought is that this might be a little too specialized. I'll add the ref-resolve method to the next alpha so this functionality can be added manually, but I don't currently think it should be default behaviour. However, I'll keep this in mind as a possible future addition.

@clyfe clyfe closed this Jan 11, 2020
@clyfe
Copy link
Author

clyfe commented Jan 11, 2020

Standalone implementation here: https://github.com/tape-framework/refmap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RefMap or resolve as protocol method
2 participants