Add ref-resolve as RefLike protocol method #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weavejester
requested changes
Jan 4, 2020
weavejester
requested changes
Jan 8, 2020
clyfe
force-pushed
the
feature/65-reflike-resolve
branch
from
ef112eb
to
c306ebd
Compare
weavejester
requested changes
Jan 8, 2020
clyfe
force-pushed
the
feature/65-reflike-resolve
branch
from
c306ebd
to
87c22ab
Compare
|
Thanks! Can you update the commit message to: Then it should be good to merge. |
This allows custom references to be added that resolve in different ways. For example, a RefMap type might act the same as a RefSet, but include the keys for each referenced value. See issue weavejester#63.
clyfe
force-pushed
the
feature/65-reflike-resolve
branch
from
87c22ab
to
12abc93
Compare
clyfe
pushed a commit
to clyfe/integrant
that referenced
this pull request
Nov 30, 2020
These methods allow a RefLike implementation to determine which dependencies are optional for a reflike, and which dependencies are mandatory. Also renames `include-refsets?` to `optional-deps?`. Resolves: weavejester#77 See also: weavejester#63, weavejester#68
clyfe
pushed a commit
to clyfe/integrant
that referenced
this pull request
Dec 5, 2020
These methods allow a RefLike implementation to determine which dependencies are optional for a reflike, and which dependencies are mandatory. Also renames `include-refsets?` to `optional-deps?`. Resolves: weavejester#77 See also: weavejester#63, weavejester#68
clyfe
pushed a commit
to clyfe/integrant
that referenced
this pull request
Dec 5, 2020
These methods allow a RefLike implementation to determine which dependencies are optional for a reflike, and which dependencies are mandatory. Resolves: weavejester#77 See also: weavejester#63, weavejester#68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows implementing "RefThing"s beyond just Ref & RefSet that resolve
in a custom way. For example a RefMap would be like RefSet but would
resolve to a map
{k -> ref}instead a refs set.Related to #63