Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add :default case for directory? #2

Closed
wants to merge 1 commit into from
Closed

Add :default case for directory? #2

wants to merge 1 commit into from

Conversation

arichiardi
Copy link
Contributor

Closes #1

@weavejester
Copy link
Owner

Thanks! Could you add a simple test and change , closes #1 to (fixes #1)? Then I'll merge. :)

@arichiardi
Copy link
Contributor Author

Yes I will address this

@arichiardi arichiardi closed this Feb 19, 2017
@arichiardi arichiardi deleted the directory-default branch February 19, 2017 17:57
@weavejester
Copy link
Owner

You don't need to close the PR - you can just push to the branch the PR is associated with.

@arichiardi
Copy link
Contributor Author

arichiardi commented Feb 19, 2017 via email

@arichiardi
Copy link
Contributor Author

arichiardi commented Feb 19, 2017 •
edited

If you want to reopen this one,. I will send the fixes here. I just need to send the branch to origin again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arichiardi @weavejester