Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and documentation. #2

Merged
merged 40 commits into from
Aug 10, 2017
Merged

Add tests and documentation. #2

merged 40 commits into from
Aug 10, 2017

Conversation

weaverba137
Copy link
Owner

This PR:

Note that the documentation part isn't actually done yet. I just needed a PR number to refer to.

@weaverba137 weaverba137 self-assigned this Aug 8, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.6%) to 41.612% when pulling d1482dc on tests-and-docs into 7852e65 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 36.226% when pulling 2a3a747 on tests-and-docs into 7852e65 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 36.226% when pulling 2a3a747 on tests-and-docs into 7852e65 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 36.226% when pulling 2a3a747 on tests-and-docs into 7852e65 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.07%) to 35.985% when pulling c8be3dc on tests-and-docs into 7852e65 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 40.951% when pulling 71cf771 on tests-and-docs into 7852e65 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 40.653% when pulling fc39275 on tests-and-docs into 7852e65 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 40.653% when pulling ef18d78 on tests-and-docs into 7852e65 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 40.653% when pulling ef18d78 on tests-and-docs into 7852e65 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 40.653% when pulling ef18d78 on tests-and-docs into 7852e65 on master.

@weaverba137
Copy link
Owner Author

@sbailey, could you take a look at this, in particular the new documentation, the files configuration.rst and using.rst?

@weaverba137
Copy link
Owner Author

PS, I'm still working on some unit tests, but the documentation should be ready to go.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 43.297% when pulling 03d819d on tests-and-docs into 7852e65 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.2%) to 43.297% when pulling d978f62 on tests-and-docs into 7852e65 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.3%) to 46.377% when pulling 3c0a184 on tests-and-docs into 7852e65 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.3%) to 46.377% when pulling 1c0b636 on tests-and-docs into 7852e65 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+5.3%) to 46.377% when pulling 509383f on tests-and-docs into 7852e65 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+9.7%) to 50.725% when pulling 9c9c31f on tests-and-docs into 7852e65 on master.

@weaverba137
Copy link
Owner Author

I'm satisfied with the current state of the unit tests, so this can be merged after the documentation is reviewed.

@coveralls
Copy link

Coverage Status

Coverage increased (+9.7%) to 50.725% when pulling 911e70e on tests-and-docs into 7852e65 on master.

@sbailey
Copy link

sbailey commented Aug 10, 2017

Thank you. This is good, especially the configuration documentation and the explained idioms. Go ahead and merge when ready.

@weaverba137 weaverba137 merged commit 2a93604 into master Aug 10, 2017
@weaverba137 weaverba137 deleted the tests-and-docs branch August 10, 2017 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add etc/desi.json validation tools add more desi.json documentation
3 participants