Get home directory in platform-independent way #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverba137
pushed a commit
that referenced
this pull request
Jan 8, 2016
Get home directory in platform-independent way
|
Heh, indeed, I don't normally consider Windows when writing code. This is a good trick to know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of building a conda package for the latest pydl release in astropy/conda-builder-affiliated#84 @bsipocz and found that one of the scripts fails on Windows. Turns out the issue is that the environment variable
$HOMEis not typically set on Windows, and the script used it to set a default value for a couple of arguments.This PR fixes that. For the conda package for 0.4.1 we'll just skip the test of that script (
pca_gal) -- in the future if you'd prefer that we not build it at all for Windows, let me know.