refs & includes being parsed as files #1
Comments
weaverryan
pushed a commit
that referenced
this issue
May 4, 2022
…ng a Service Locator" section (jbieliauskas) This PR was merged into the 4.4 branch. Discussion ---------- [DependencyInjection] Fix YAML example in "Defining a Service Locator" section Using this example in `v5.3.13` gives this error: ``` Symfony\Component\DependencyInjection\Definition::setArguments(): Argument #1 ($arguments) must be of type array, Symfony\Component\DependencyInjection\Argument\ServiceLocatorArgument given, called in /project/vendor/symfony/dependency-injection/Loader/YamlFileLoader.php on line 527 ``` I assume this is because `!service_locator` is the first constructor argument but it's passed as an array of constructor arguments, in which case the example is not right. <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- bd8b262 Fix YAML example in "Defining a Service Locator" section
weaverryan
pushed a commit
that referenced
this issue
Jul 22, 2022
hello, when running the example as it is, a deprecation message is shown (i'm on PHP 8.1.6). the deprecation message says that ``trim(): Passing null to parameter #1 ($string) of type string is deprecated``. what if we add a normalizer that returns an empty string when the entered value is `null` otherwise returns the user's intial input. with this suggestion, the example works great
weaverryan
pushed a commit
that referenced
this issue
Jul 22, 2022
…1989) This PR was submitted for the 6.0 branch but it was merged into the 4.4 branch instead. Discussion ---------- [Console] Update questionhelper.rst hello, when running the example as it is, a deprecation message is shown (i'm on PHP 8.1.6). the deprecation message says that ``trim(): Passing null to parameter #1 ($string) of type string is deprecated``. what if we add a normalizer that returns an empty string when the entered value is `null` otherwise returns the user's intial input. with this suggestion, the example works great <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/releases for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `6.x` for features of unreleased versions). --> Commits ------- bf9e245 Update questionhelper.rst
weaverryan
pushed a commit
that referenced
this issue
Nov 27, 2023
- parameter $year is typed with integer. date function returns string. Code works but casting to the right type feels better. - added missing import to fix TypeError "Argument #1 ($request) must be of type Request"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The parser currently adds all
:ref:,:docand*.rst.incto the parse queue.That's why this line exists: https://github.com/doctrine/rst-parser/blob/master/lib/Builder.php#L358
This should raise an error instead, because a file added in the parser that could not
be found means something goes wrong. However, this currently can't be done because too many things are being included: the parser sees all dependencies (doc, ref or include) as equivalent.
:docshould be treated like currently: these files should be added to the parser queue:refshould not be added to the parser queue everincludeshould somehow be "inlined" - not added to the parser queueThe text was updated successfully, but these errors were encountered: