Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create netns per microvm #206

Open
richardcase opened this issue Nov 4, 2021 · 4 comments
Open

Create netns per microvm #206

richardcase opened this issue Nov 4, 2021 · 4 comments
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@richardcase
Copy link
Member

richardcase commented Nov 4, 2021 •
edited
Loading

We should be creating a network namespace per microvm and the host network interfaces should live in that namespace. This can potentially be done via CNI with #14.

The network namespace will then be used when using the Jailer (#205).
@richardcase richardcase mentioned this issue Nov 10, 2021
Closed
@richardcase
Copy link
Member Author

richardcase commented Nov 10, 2021 •
edited by Callisto13
Loading

  • Check if this a mandatory arg to the jailer

It is not

@richardcase richardcase added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 10, 2021
@richardcase richardcase mentioned this issue Nov 24, 2021
Open
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 24, 2022
@Callisto13 Callisto13 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2022
@github-actions
Copy link
Contributor

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 19, 2023
yitsushi added a commit that referenced this issue May 19, 2023
@yitsushi
refactor: resolve/remove TODO comments
caffd11 
* #179 not relevant anymore
* Closes #233 becasue closer inspection, those errors can happen,
  but that does not mean the application has serious issues, the next loop can
  be successful, if it stuck in an error loop, it is visible in logs.
* #206, we have an issue to track that, we don't need an extra comment about it.
* Closes #235, we can return with an error, and the caller can handle it.

Additional changes:
* If any of the main processes returns with an error, stop all other processes,
  for example if `serveAPI` fails, we can stop `runControllers` too.

References:
* #179
* #233
* #206
* #235

Signed-off-by: Balazs Nadasdi <balazs@weave.works>
@yitsushi yitsushi mentioned this issue May 19, 2023
Merged
yitsushi added a commit that referenced this issue May 25, 2023
@yitsushi
refactor: resolve/remove TODO comments (#709)
eb239ae 
* #179 not relevant anymore
* Closes #233 becasue closer inspection, those errors can happen,
  but that does not mean the application has serious issues, the next loop can
  be successful, if it stuck in an error loop, it is visible in logs.
* #206, we have an issue to track that, we don't need an extra comment about it.
* Closes #235, we can return with an error, and the caller can handle it.

Additional changes:
* If any of the main processes returns with an error, stop all other processes,
  for example if `serveAPI` fails, we can stop `runControllers` too.

References:
* #179
* #233
* #206
* #235

Signed-off-by: Balazs Nadasdi <balazs@weave.works>
@github-actions GitHub Actions
Copy link
Contributor

This issue was closed because it has been stalled for 365 days with no activity.

@github-actions github-actions bot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 18, 2024
@richardcase richardcase reopened this Jul 10, 2024
@richardcase richardcase removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
No open projects
Liquid Metal Roadmap - Public
Status: Closed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@richardcase @Callisto13