Disable root volume validation #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The firecracker docs say that only you can only specific either a root volume or an initrd. However, when we remove the root volume and only have initrd the mvm will not start. We are not entirely sure what is happening yet, so for now we are going to disable the validation and continue using both a root vol and initrd. It's more of a guideline than an actual rule anyway ;) There is a separate ticket to track the investigation and potential fix here: liquidmetal-dev#219 (Also added a missing test, the removed bit also was not covered so we should remember to add one when/if we put it back)
jmickey
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firecracker docs say that only you can only specify either a root
volume or an initrd. However, when we remove the root volume and only
have initrd (or vice-versa) the mvm will not start. 🤷♀️
We are not entirely sure what is happening yet, so for now we are going
to disable the validation and continue using both a root vol and
initrd. It's more of a guideline than an actual rule anyway 😉
There is a separate ticket to track the investigation and potential fix
here: #219
(Also added a missing test, the removed bit also was not covered so we
should remember to add one when/if we put it back)
What this PR does / why we need it:
Disables a volume validation check for the timebeing while we figure out the above issue. If we leave it in then we will be annoyed by all the failing.
Checklist: