-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add developer docs #228
Conversation
Codecov Report
@@ Coverage Diff @@
## main #228 +/- ##
==========================================
- Coverage 55.81% 53.66% -2.15%
==========================================
Files 44 46 +2
Lines 2012 2139 +127
==========================================
+ Hits 1123 1148 +25
- Misses 781 885 +104
+ Partials 108 106 -2
Continue to review full report at Codecov.
|
bb70ef2
to
88c0af1
Compare
56833be
to
9301380
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the best contributing guides i've read!
f6e8852
to
0c14982
Compare
Every issue will be assigned a `priority/<x>` label. The levels of priorities are: | ||
|
||
- [`critical-urgent`](https://github.com/weaveworks/flintlock/labels/priority%2Fcritical-urgent): These are time sensitive issues which should be picked up immediately. | ||
If an issue labelled `critical` is not assigned or being actively worked on, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, maybe in this block all instances of cirtical
could be changed to critical-urgent
. But thats being a bit pedantic i feel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops sorry just saw this 😬
Shiny new contrib docs!
What copy-paste? Who said anything about copy-paste? I will not stand for these accusations! (does it make it better if i copied from my past self?)
Might be easier to read fully rendered.
I have added our latest ADR process too (per slack discussion).
Can tweak anything 👍
There is a TODO (testing standards) but I will add that later as i would like to have a discussion around it first.