Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Documentation site publish if it's a forked repo #251

Merged

Conversation

yitsushi
Copy link
Contributor

What this PR does / why we need it:

It's annoying, every time I update my fork, I get a notification about the failed GitHub Action. It tries to use a secret with SSH key, but I don't have one on my fork.

Which issue(s) this PR fixes:
Fixes #250

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes

@yitsushi yitsushi added the kind/cleanup Removing things previously overlooked label Nov 11, 2021
@yitsushi yitsushi changed the title Disable ghpage publish on forks Disable Documentation site publish if it's a forked repo Nov 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #251 (9d9466d) into main (fe9bb9f) will decrease coverage by 15.61%.
The diff coverage is 41.78%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #251       +/-   ##
===========================================
- Coverage   55.81%   40.20%   -15.62%     
===========================================
  Files          44       46        +2     
  Lines        2012     2169      +157     
===========================================
- Hits         1123      872      -251     
- Misses        781     1237      +456     
+ Partials      108       60       -48     
Impacted Files Coverage Δ
core/application/commands.go 71.66% <ø> (+2.70%) ⬆️
core/application/reconcile.go 0.00% <ø> (ø)
core/models/vmid.go 90.24% <ø> (ø)
core/models/volumes.go 0.00% <ø> (ø)
core/steps/microvm/delete.go 100.00% <ø> (ø)
core/steps/runtime/dir_create.go 73.07% <ø> (ø)
core/steps/runtime/dir_delete.go 81.81% <ø> (ø)
core/steps/runtime/initrd_mount.go 100.00% <ø> (ø)
core/steps/runtime/kernel_mount.go 100.00% <ø> (ø)
infrastructure/containerd/content.go 0.00% <0.00%> (-100.00%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1980c5c...9d9466d. Read the comment docs.

@yitsushi yitsushi merged commit 9cde2a1 into weaveworks-liquidmetal:main Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Removing things previously overlooked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Documentation site publish if it's a forked repo
3 participants