Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this patch, a GCE instance could be named:
"host5-94-1"
With this patch, it should be named:
"host5-weaveworks-scope-94-1"
When several GitHub forks are configured to use CircleCI with the same
GCE account, that would distinguish the VMs.
Also, when the scripts are used without CircleCI, still add a suffix
with a username, e.g.
"host5-alban"
I reused the same namespacing idea as in:
weaveworks/scope@65291308#diff-42138a4802cce915f347919ccd707876L21
I marked this as WIP because I still need to test it.
xref weaveworks/scope#2192
/cc @2opremio @marccarre