Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont error when the cluster secret doesn't exist. #7

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

bigkevmcd
Copy link
Contributor

This alters the behaviour when attempting to find the cluster access
secret, instead of returning an error, set a requeue time.

This means that the reconciliation of the cluster is not subject to the
reconciler backoff mechanism.

Currently the requeue time is fixed at 30s.

Copy link
Collaborator

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

This alters the behaviour when attempting to find the cluster access
secret, instead of returning an error, set a requeue time.

This means that the reconciliation of the cluster is not subject to the
reconciler backoff mechanism.

Currently the requeue time is fixed at 30s.
@yiannistri yiannistri force-pushed the dont-err-if-secret-not-found branch from b63c670 to 0feb151 Compare April 7, 2022 08:27
@yiannistri yiannistri merged commit b3cd729 into main Apr 7, 2022
@yiannistri yiannistri deleted the dont-err-if-secret-not-found branch April 7, 2022 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants