Replace node_exporter https package with exporter-toolkit #230
Conversation
The node_exporter/https package has been moved to exporter-toolkit as of v1.1.0. weaveworks/common was still using this package, which was preventing downstream importers (i.e., grafana/agent) from updating their dependency on node_exporter. This change also required bumping kuberesolver to v2.4.0 (the next version after v2.1.0) which uses a newer version of the gRPC library where type names have changed. kuberesolver diff: sercand/kuberesolver@v2.1.0...v2.4.0
server/server_test.go
Outdated
| tcp_connections{protocol="http"} 0 | ||
| tcp_connections{protocol="grpc"} 0 | ||
| `), "request_message_bytes", "response_message_bytes", "inflight_requests", "tcp_connections")) | ||
| # HELP inflight_requests Current number of inflight requests. |
There was a problem hiding this comment.
Eugh, sorry, gopls format did this. Should I revert?
|
🤔 Looking into lint/test errors. This had worked on my machine just fine, which makes me feel like I probably have a newer Go version which is being helpful. |
prometheus/exporter-toolkit requires 1.14
rfratto
force-pushed
the
use-exporter-toolkit
branch
from
55c3325
to
71e5cb1
Compare
Oh 😞 exporter-toolkit requires at least Go 1.14. I bumped the versions here, but I'm concerned about how much that bloats up this PR. |
Do you think you could list the main points in English rather than asking everyone to read the diffs? Not too bothered about the whitespace changes, as long as they are called out in the commit message. Updating to Go 1.14 is fine; kuberesolver and gRPC are the main things which catch my eye as potentially affecting systems. |
@bboreham Absolutely.
gRPC has changed more dramatically between v1.26 and v1.31. I'll link to their releases which each have changelogs:
(For reference, the latest Prometheus release is using v1.40.0, if that means that this module should too) |
The node_exporter/https package has been moved to exporter-toolkit as of v1.1.0. weaveworks/common was still using this package, which was preventing downstream importers (i.e., grafana/agent) from updating their dependency on node_exporter.
This change also required bumping kuberesolver to v2.4.0 (the next version after v2.1.0) which uses a newer version of the gRPC library where type names have changed. The kuberesolver diff between the two versions can be found here: sercand/kuberesolver@v2.1.0...v2.4.0