Skip to content

Commit

Permalink
List clusters in all regions despite regional errors
Browse files Browse the repository at this point in the history
  • Loading branch information
errordeveloper committed Jun 19, 2019
1 parent 5aeb7d2 commit 00fc45b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion integration/creategetdelete_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ var _ = Describe("(Integration) Create, Get, Scale & Delete", func() {

Context("and listing clusters", func() {
It("should return the previously created cluster", func() {
cmdSession := eksctlSuccess("get", "clusters", "--region", region)
cmdSession := eksctlSuccess("get", "clusters", "--all-regions", region)
Expect(string(cmdSession.Buffer().Contents())).To(ContainSubstring(clusterName))
})
})
Expand Down
2 changes: 1 addition & 1 deletion pkg/eks/eks.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ func (c *ClusterProvider) doListClusters(chunkSize int64, printer printers.Outpu
WaitTimeout: c.Provider.WaitTimeout(),
}
if err := New(spec, nil).doListClusters(chunkSize, printer, allClusters, false); err != nil {
return err
logger.Critical("error listing clusters in %q region: %s", region, err.Error())
}
}
return nil
Expand Down

0 comments on commit 00fc45b

Please sign in to comment.