Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Testing out an initial MD pattern for reference docs #1130

Closed
wants to merge 11 commits into from

Conversation

sbernheim
Copy link

Submitting as a WIP PR for feedback and possible testing against the docs site build pipeline tooling.

DO NOT MERGE THIS PR!


`Usage: eksctl [command] [flags]`

##### common flags<a name="common-flags"></a>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not use h4 or h5 since they are small enough to look confusing in the context of our base font size.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - let's connect Monday morning and figure out how to amend the tags. I want it to look good as rendered, but it should remain a structured doc like an outline format somehow.

@bia
Copy link
Contributor

bia commented Aug 9, 2019

Nice one!

The syntax highlighting is behaving strangely here. We could also go for line-by-line code snippets?
Screenshot 2019-08-09 at 17 50 10

@sbernheim
Copy link
Author

@bia Please take a look at 03-config-yaml.md and related links between flags and config yaml attributes when you get a chance.

We can substitute pre-formatted blocks with something else if that works better. The example for the top-level in the 01-commands.md file is just a placeholder. We can swap in whatever would work better for Hugo.

- [h, help](02-flags.md#help)
- [v, verbose](02-flags.md#verbose)

### completion <a name="completion"></a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very linux centric. Do we really need to document this behaviour here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Linux users would appreciate some documentation, yes. 😄

It's also supposed to cover MacOS usage, but I think it might be inaccurate. 😐

Reference documentation is supposed to be comprehensive, so if the code supports a feature you'll want to document that feature - no matter how trivial it may seem. If it supports tab completion for a Unix/Linux shell, it should really be documented.

This is literally cut-and-paste from the help screens, so it was easy to include. I don't know why you wouldn't.


Without an invoking a sub-command, the completion command simply prints the help screen.

#### bash <a name="completion-bash"></a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as before.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bash users are people too!!! 😄

zsh is an even more obscure shell, but someone liked it enough to write completion support for it, so who am I to judge?


Creates a mapping from IAM role to Kubernetes user and groups.

*Note:* aws-iam-authenticator only considers the last entry for any given

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`aws-iam-authenticator`

@errordeveloper
Copy link
Contributor

@sbernheim are you planning to continue working on this?

@martina-if
Copy link
Contributor

@sbernheim given that it seems we can't put much time on this right now I will close this but please feel free to reopen it if you have time again!

@martina-if martina-if closed this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants