Allow StackCollection.DeleteStackByName() to succeed #2308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martina-if
reviewed
Jun 9, 2020
pkg/cfn/manager/api.go
Outdated
| @@ -337,8 +337,7 @@ func defaultStackStatusFilter() []*string { | |||
|
|
|||
| // DeleteStackByName sends a request to delete the stack | |||
| func (c *StackCollection) DeleteStackByName(name string) (*Stack, error) { | |||
| i := &Stack{StackName: &name} | |||
| s, err := c.DescribeStack(i) | |||
| i, err := c.DescribeStack(&Stack{StackName: &name}) | |||
There was a problem hiding this comment.
nit: can we rename i to stack?
There was a problem hiding this comment.
thanks, it should be s to be consistent with other usages throughout eksctl.
(eksctl seems to use i to describe something like "input stack to perform action on". for actions that return a stack it is usually assigned to s which would denote a complete stack object having all the fields filled out.)
martina-if
approved these changes
Jun 9, 2020
rndstr
force-pushed
the
fix-delete-stack-by-name
branch
from
57d49b9
to
1c4bdce
Compare
`StackCollection.DeleteStackBySpec(*Stack)` only deletes the stack if its tags match the clustername. For that reason we not only need to pass in the `StackName` and `StackId` but also `Tags`.
rndstr
force-pushed
the
fix-delete-stack-by-name
branch
from
1c4bdce
to
e87f34c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2307
StackCollection.DeleteStackBySpec(*Stack)only deletes the stack ifits tags match the clustername. For that reason we not only need to pass
in the
StackNameandStackIdbut alsoTags.