Support arm/arm64 binaries as part of release #2725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
force-pushed
the
feature/arm64
branch
2 times, most recently
from
8ca1771
to
756eeb3
Compare
|
Sorry, I didn't see this PR before #2622. Not sure if the above PR is still active, anyway, I can close this as well. |
sayboras
force-pushed
the
feature/arm64
branch
from
7f129c7
to
64e28cc
Compare
|
@sayboras can you rebase on |
This commit is to provide arm/arm64 binary releases. Both goarm 6 and 7
are supports.
Naming will be something like eksctl_Linux_{arm,arm64,armv6,armv7}.tar.gz
Signed-off-by: Tam Mach <sayboras@yahoo.com>
sayboras
force-pushed
the
feature/arm64
branch
from
64e28cc
to
ac0c3a3
Compare
Done. Feel free to let me know if any change is required. |
michaelbeaumont
changed the title
michaelbeaumont
approved these changes
Oct 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit is to provide arm/arm64 binary releases. Both goarm 6 and 7
are supported.
Naming will be something like eksctl_Linux_{arm64,armv6,armv7}.tar.gz
Fixes #2621
Signed-off-by: Tam Mach sayboras@yahoo.com
Testing
Testing was done in forked repo https://github.com/sayboras/eksctl/releases/tag/v0.30.0, please refer to the below:
Testing in new release in forked repo sayboras/eksctl
$ goreleaser release --rm-dist • releasing... • loading config file file=.goreleaser.yml • running before hooks • loading environment variables • getting and validating git state • releasing v0.30.0, commit 8ca1771bd1e25273146fbb0292b75ec7f585c628 • parsing tag • setting defaults • snapshotting • github/gitlab/gitea releases • project name • building binaries • creating source archive • archives • linux packages • snapcraft packages • calculating checksums • signing artifacts • docker images • artifactory • blobs • homebrew tap formula • scoop manifests • snapshotting • pipe skipped error=not a snapshot • checking ./dist • --rm-dist is set, cleaning it up • writing effective config file • writing config=dist/config.yaml • generating changelog • writing changelog=dist/CHANGELOG.md • building binaries • building binary=/home/tammach/go/src/github.com/weaveworks/eksctl/dist/default_linux_arm_7/eksctl • building binary=/home/tammach/go/src/github.com/weaveworks/eksctl/dist/default_linux_arm64/eksctl • building binary=/home/tammach/go/src/github.com/weaveworks/eksctl/dist/default_darwin_amd64/eksctl • building binary=/home/tammach/go/src/github.com/weaveworks/eksctl/dist/default_windows_amd64/eksctl.exe • building binary=/home/tammach/go/src/github.com/weaveworks/eksctl/dist/default_linux_arm_6/eksctl • building binary=/home/tammach/go/src/github.com/weaveworks/eksctl/dist/default_linux_amd64/eksctl • archives • creating archive=dist/eksctl_Darwin_amd64.tar.gz • creating archive=dist/eksctl_Linux_armv6.tar.gz • creating archive=dist/eksctl_Windows_amd64.zip • creating archive=dist/eksctl_Linux_arm64.tar.gz • creating archive=dist/eksctl_Linux_armv7.tar.gz • creating archive=dist/eksctl_Linux_amd64.tar.gz • creating source archive • pipe skipped error=source pipe is disabled • linux packages • snapcraft packages • calculating checksums • checksumming file=eksctl_Linux_amd64.tar.gz • checksumming file=eksctl_Linux_armv7.tar.gz • checksumming file=eksctl_Windows_amd64.zip • checksumming file=eksctl_Linux_armv6.tar.gz • checksumming file=eksctl_Linux_arm64.tar.gz • checksumming file=eksctl_Darwin_amd64.tar.gz • signing artifacts • docker images • pipe skipped error=docker section is not configured • publishing • blobs • pipe skipped error=blobs section is not configured • http upload • pipe skipped error=uploads section is not configured • custom publisher • pipe skipped error=publishers section is not configured • artifactory • pipe skipped error=artifactory section is not configured • docker images • snapcraft packages • github/gitlab/gitea releases • token type type=github • creating or updating release repo=sayboras/eksctl tag=v0.30.0 • release updated url=https://github.com/sayboras/eksctl/releases/tag/v0.30.0 • uploading to release file=dist/eksctl_checksums.txt name=eksctl_checksums.txt • uploading to release file=dist/eksctl_Windows_amd64.zip name=eksctl_Windows_amd64.zip • uploading to release file=dist/eksctl_Linux_armv6.tar.gz name=eksctl_Linux_armv6.tar.gz • uploading to release file=dist/eksctl_Linux_armv7.tar.gz name=eksctl_Linux_armv7.tar.gz • uploading to release file=dist/eksctl_Darwin_amd64.tar.gz name=eksctl_Darwin_amd64.tar.gz • uploading to release file=dist/eksctl_Linux_arm64.tar.gz name=eksctl_Linux_arm64.tar.gz • uploading to release file=dist/eksctl_Linux_amd64.tar.gz name=eksctl_Linux_amd64.tar.gz • homebrew tap formula • token type type=github • scoop manifests • token type type=github • pipe skipped error=scoop section is not configured • release succeeded after 76.63sDownload the above binary from ARM node:
Checklist
README.md, or theuserdocsdirectory)area/nodegroup), target version (e.g.version/0.12.0) and kind (e.g.kind/improvement)