Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set/Unset/Get labels on unowned nodegroups #3168

Merged
merged 2 commits into from Feb 1, 2021
Merged

Set/Unset/Get labels on unowned nodegroups #3168

merged 2 commits into from Feb 1, 2021

Conversation

Callisto13
Copy link
Contributor

@Callisto13 Callisto13 commented Jan 28, 2021 •
edited

Description

  • Refactored existing bits into pkg/actions/
  • Can now perform labels ops on unowned managed nodegroups
  • Fixed a couple of UI bugs and added tests around them
  • Plus Integration tests

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@Callisto13 Callisto13 linked an issue Jan 28, 2021 that may be closed by this pull request
eksctl set/unset labels support for non-eksctl created cluster #2810
Closed
@Callisto13 Callisto13 force-pushed the non-eksctl-labels branch 2 times, most recently from c3bd7b7 to 4bfa9ba Compare January 29, 2021 10:30
@Callisto13 Callisto13 marked this pull request as ready for review January 29, 2021 10:30
@Callisto13 Callisto13 requested a review from a team January 29, 2021 10:40
aclevername
aclevername approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, couple nits

Callisto13 and others added 2 commits February 1, 2021 09:35
@Callisto13 Callisto13 merged commit 99ed69d into eksctl-io:master Feb 1, 2021
@Callisto13 Callisto13 deleted the non-eksctl-labels branch February 1, 2021 10:12
@Callisto13 Callisto13 mentioned this pull request Feb 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclevername aclevername aclevername approved these changes

Assignees
No one assigned
Labels
kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eksctl set/unset labels support for non-eksctl created cluster
2 participants
@Callisto13 @aclevername