Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sourceSecurityGroupIds for unmanaged nodegroups #3254

Merged
merged 6 commits into from Feb 11, 2021
Merged

Support sourceSecurityGroupIds for unmanaged nodegroups #3254

merged 6 commits into from Feb 11, 2021

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Feb 11, 2021 •
edited

Description

Adds support for nodegroup.ssh.sourceSecurityGroupIds for unmanaged nodegroups.

Closes #2366

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@cPu1 cPu1 added the kind/feature New feature or request label Feb 11, 2021
@cPu1 cPu1 mentioned this pull request Feb 11, 2021
Closed
@cPu1 cPu1 marked this pull request as ready for review February 11, 2021 12:28
@cPu1 cPu1 marked this pull request as draft February 11, 2021 13:27
@cPu1 cPu1 marked this pull request as ready for review February 11, 2021 13:30
aclevername
aclevername approved these changes Feb 11, 2021
View reviewed changes
Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cPu1 cPu1 merged commit 0dac7db into eksctl-io:main Feb 11, 2021
@cPu1 cPu1 deleted the unmanaged-source-sg branch February 11, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclevername aclevername aclevername approved these changes

Assignees
No one assigned
Labels
area/nodegroup kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SourceSecurityGroupIDs doesn't work in unmanaged node group, but this is not mentioned in the config schema.
2 participants
@cPu1 @aclevername