Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add well-known IAM Role Service Account policy for the EBS CSI driver #3518

Merged
merged 2 commits into from Apr 19, 2021

Conversation

jalaziz
Copy link
Contributor

@jalaziz jalaziz commented Apr 4, 2021

Description

Add well-known IAM policy support for EBS CSI driver/controller IAM role
service accounts.

The EBS CSI driver is a common installation that should probably be supported by a well-known policy.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@jalaziz jalaziz changed the title Add well-known IRSA policy for the EBS CSI driver Add well-known IAM Role Service Account policy for the EBS CSI driver Apr 6, 2021
@Callisto13
Copy link
Contributor

Callisto13 commented Apr 9, 2021

Thanks for this @jalaziz 馃憤 .

Just thinking, I am not sure we have docs for this wellKnownPolicies thing 馃 . Do you think you could add some listing the options people have?

@jalaziz
Copy link
Contributor Author

jalaziz commented Apr 9, 2021

Thanks for this @jalaziz 馃憤 .

Just thinking, I am not sure we have docs for this wellKnownPolicies thing 馃 . Do you think you could add some listing the options people have?

Was thinking the same thing actually. Will add some docs.

@jalaziz
Copy link
Contributor Author

jalaziz commented Apr 10, 2021

@Callisto13 Turns out there were docs, it was just very subtle.

I've tried to improve the docs a bit.

Add well-known IAM policy support for EBS CSI driver/controller IAM role
service accounts.
@jalaziz
Copy link
Contributor Author

jalaziz commented Apr 18, 2021

@Callisto13 anything else to improve with this PR?

@Callisto13
Copy link
Contributor

hey @jalaziz thanks for your patience: we were having a little existential crisis on the wellKnownPolicies feature, but all good now 馃槀

Copy link
Contributor

@Callisto13 Callisto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 馃帀

@Callisto13 Callisto13 merged commit 2ff9e67 into eksctl-io:main Apr 19, 2021
@Callisto13 Callisto13 mentioned this pull request Apr 19, 2021
7 tasks
@jalaziz jalaziz deleted the ebs-irsa-wellknown-policy branch April 19, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants