Use the AutoScalingGroup for getting & scaling the nodegroups #3543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aclevername
force-pushed
the
asg-scale
branch
2 times, most recently
from
e1d00d0
to
f561b0b
Compare
aclevername
changed the title
aclevername
force-pushed
the
asg-scale
branch
2 times, most recently
from
58916cb
to
c8e8b8f
Compare
…degroups scaling config
Callisto13
reviewed
Apr 9, 2021
pkg/cfn/manager/nodegroup.go
Outdated
Comment on lines
205
to
209
| if name == "" { | ||
| summaries = append(summaries, summary) | ||
| } else if summary.Name == name { | ||
| summaries = append(summaries, summary) | ||
| } |
There was a problem hiding this comment.
I'm just preserving the existing weird logic, not me! its some hack for searching for an individual nodegroup vs all.
Callisto13
approved these changes
Apr 9, 2021
cPu1
approved these changes
Apr 9, 2021
Co-authored-by: Chetan Patwal <cPu1@users.noreply.github.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the
get nodegrouplogic to fetch it from the ASG/EKS nodegroup instead of from the cloudformation as that can be out of date. Scale now modifys the ASG/EKS nodegroup directly as the cloudformation can drift away from the actual values due to cluster-autoscaler, simpler to just acknlowedge its not a true representation of the state and not use it rather than occasionally modifying it to be up to date.Example
Get
For example if I now create two nodegroups:
If I manually modify the
desiredto2andmaxSizeto3for bothGetnow returns:Where as before it would of returned:
Scale
Before if you attempted to scale just the
minormax, thedesiredvalue would go back to what was written in cloudformation, overriding any manual changes. This no longer happens, for example:However if I attempt the same set of commands with the previous version of eksctl it would of reverted the
minanddesiredback to the original for unmanaged nodegroups:Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯