Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing releaseVersion for Managed Nodegroups #3544

Merged
merged 4 commits into from Apr 9, 2021
Merged

Support passing releaseVersion for Managed Nodegroups #3544

merged 4 commits into from Apr 9, 2021

Conversation

cPu1
Copy link
Collaborator

@cPu1 cPu1 commented Apr 8, 2021 •
edited

Description

Closes #3506

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@cPu1 cPu1 added the kind/feature New feature or request label Apr 9, 2021
@cPu1 cPu1 marked this pull request as ready for review April 9, 2021 11:53
@cPu1 cPu1 mentioned this pull request Apr 9, 2021
Merged
@cPu1 cPu1 merged commit acfd507 into eksctl-io:main Apr 9, 2021
@cPu1 cPu1 deleted the mng-release-version branch April 9, 2021 12:52
@cPu1 cPu1 mentioned this pull request Apr 13, 2021
Closed
@kr3cj kr3cj mentioned this pull request May 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Callisto13 Callisto13 Callisto13 approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for multiple AMI release versions in managed node groups
2 participants
@cPu1 @Callisto13