Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preBootstrapCommands to userdata when using customAMI #4065

Merged
merged 9 commits into from Aug 24, 2021

Conversation

kishoregv
Copy link
Contributor

@kishoregv kishoregv commented Aug 9, 2021

Description

Will fix #4032

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

@kishoregv kishoregv changed the title Add preBootstrapCommands to userdata when using customAMI [WIP] Add preBootstrapCommands to userdata when using customAMI Aug 10, 2021
@Callisto13
Copy link
Contributor

馃憤 thanks @kishoregv.

Can you make this a draft while it is still WIP? That way it will be easy for us to spot when it is ready for review 馃檹

@kishoregv kishoregv changed the title [WIP] Add preBootstrapCommands to userdata when using customAMI Add preBootstrapCommands to userdata when using customAMI Aug 10, 2021
@kishoregv
Copy link
Contributor Author

kishoregv commented Aug 10, 2021

Can you make this a draft while it is still WIP? That way it will be easy for us to spot when it is ready for review 馃檹

Thanks for the advice. Will do that in future.

The PR is now ready for review.

Thanks

@Callisto13
Copy link
Contributor

馃憤 could you add some testing to pkg/nodebootstrap/managed_al2_test.go please?

@Himangini
Copy link
Collaborator

@kishoregv can you resolve the conflicts, please. We can then proceed to review and merge this PR :)

@kishoregv
Copy link
Contributor Author

@kishoregv can you resolve the conflicts, please. We can then proceed to review and merge this PR :)

@Himangini Done.馃憤

Copy link
Contributor

@Callisto13 Callisto13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Callisto13 Callisto13 enabled auto-merge (squash) August 24, 2021 13:32
@Callisto13 Callisto13 merged commit 8bcd365 into eksctl-io:main Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to set preBootstrapCommands when using custom ami with managed nodegroups
3 participants