Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AppMesh access #651

Merged
merged 4 commits into from
Mar 21, 2019
Merged

AppMesh access #651

merged 4 commits into from
Mar 21, 2019

Conversation

errordeveloper
Copy link
Contributor

@errordeveloper errordeveloper commented Mar 20, 2019 •
edited
Loading

Description

Add --appmesh-access to enable nodegroups to access AppMesh API easily

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All unit tests passing (i.e. make test)

stefanprodan
stefanprodan previously approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested with a new node group. Thanks @errordeveloper

@errordeveloper
Copy link
Contributor Author

I'd like to add unit tests, and then we can merge! :)

@errordeveloper errordeveloper mentioned this pull request Mar 21, 2019
Merged
6 tasks
@errordeveloper errordeveloper merged commit ca30d42 into master Mar 21, 2019
@errordeveloper errordeveloper deleted the appmesh-access branch March 21, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanprodan stefanprodan stefanprodan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@errordeveloper @stefanprodan