Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new site in Hugo #857

Merged
merged 11 commits into from
Jun 13, 2019
Merged

Add new site in Hugo #857

merged 11 commits into from
Jun 13, 2019

Conversation

martina-if
Copy link
Contributor

This new site will contain more documentation and examples

site/content/_index.md Outdated Show resolved Hide resolved
site/content/community/02-roadmap.md Show resolved Hide resolved
site/content/usage/09-iam-policies.md Outdated Show resolved Hide resolved
weight: 10
---

# `eksctl` - a CLI for Amazon EKS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top part of it seems to be the same as the home page... something that we will need to address.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I'm not sure what do do between those two. What do you think?

@errordeveloper
Copy link
Contributor

@martina-if do you have a preview URL or instruction for someone to build it locally?

@martina-if martina-if force-pushed the add-hugo-site branch 2 times, most recently from ddaf140 to dc2f938 Compare June 10, 2019 16:02
@martina-if
Copy link
Contributor Author

This is a preview from my fork: https://confident-sammet-4a692a.netlify.com/

To build it locally:

  • install Hugo v0.55.6
  • cd site/
  • hugo serve -D
  • visit http://localhost:1313

I may have forgotten some step but I think that was basically it. Let me know if it doesn't work.

@gemagomez
Copy link

LGTM, let's merge and work on the next improvements afterwards

@kalbir
Copy link

kalbir commented Jun 13, 2019

For me page renders oddly on mobile -- specifically on Firefox and Chrome on Android. The words "eksctl" "create" & "cluster" are cascading down the page.

If there's an easy fix might be nice to get that sorted.

@bia
Copy link
Contributor

bia commented Jun 13, 2019

Good catch @kalbir! That's coming from some hack-y css on my part. I'll look into it now.

@bia
Copy link
Contributor

bia commented Jun 13, 2019

Most mobile platforms are good now,
Screenshot 2019-06-13 at 14 23 24

@bia bia mentioned this pull request Jun 13, 2019
9 tasks
@martina-if martina-if merged commit b5e7257 into eksctl-io:master Jun 13, 2019
torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022
add pod disruption budget for csi controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants