Add tests for updateDependencies #1562
Conversation
Added tests to ensure that this functions behaviour with helm is always defined.
|
Tests pass locally. I'm not sure how to proceed it looks like helm can't update the repository. |
|
I suspect that it's because Suggestion: we download the helm client as part of the build, so it could just be a dependency of NB when I try this locally, it's the non-existent chart test that fails, i.e., it doesn't return an error. We can see if that's the case in CI .. |
|
Update: added grin for first-time contributor -- thanks for this PR! |
Some tests may depend on the helm binary, so make it a dependency. And, since we want to test with the binary that's being baked into the image, put it first on the $PATH.
Running locally, it's likely that you'll already have helm set up; but this isn't the case in CI, and only a coincidence. Therefore, create a temp directory and use that as Helm's home dir when testing.
|
@mgazza Are you happy for me to push a couple of commits here? |
|
Hi @squaremo, |
|
@hiddeco Mind having a look at this one when you have a chance? I ought to recuse myself on the basis that I've added commits :-) |
Added tests to ensure that this functions behaviour with helm is always defined.