This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
Reimplement Git timeout Helm operator #1565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
Signed-off-by: Hidde Beydals <hello@hidde.co>
|
I tested and it's working for my case. Thanks! |
stefanprodan
approved these changes
Dec 4, 2018
squaremo
approved these changes
Dec 4, 2018
| @@ -60,16 +60,16 @@ fluxd requires setup and offers customization though a multitude of flags. | |||
| |--git-label | | label to keep track of sync progress; overrides both --git-sync-tag and --git-notes-ref| | |||
| |--git-sync-tag | `flux-sync` | tag to use to mark sync progress for this cluster (old config, still used if --git-label is not supplied)| | |||
| |--git-notes-ref | `flux` | ref to use for keeping commit annotations in git notes| | |||
| |--git-poll-interval | `5 minutes` | period at which to fetch any new commits from the git repo | | |||
| |--git-timeout | `20 seconds` | duration after which git operations time out | | |||
| |--git-poll-interval | `5m` | period at which to fetch any new commits from the git repo | | |||
There was a problem hiding this comment.
Just noticed there are some more inconsistencies in the docs (https://github.com/weaveworks/flux/pull/1565/files#diff-91111368d299d9de710705677c1ad0f6R28 is not a valid flag, same goes for https://github.com/weaveworks/flux/pull/1565/files#diff-91111368d299d9de710705677c1ad0f6L33) but I will address them in an additional PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1551, supersedes #1552.
Image available for testing as
hiddeco/helm-operator:1551-git-timeout-fix-2.