Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

add "skipDepUpdate" config parameter to HelmRelease #1712

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

yinzara
Copy link

@yinzara yinzara commented Feb 7, 2019

some helm charts (istio being an example) add helm charts into the "charts" folder directly and do not need "helm dep up" to be called. In fact doing so will cause an error since the requirements have already been fulfilled. While you can disable this feature system wide it is much more useful to allow individual helm releases to specify this behavior. this commit adds a skipDepUpdate attribute to the
HelmRelease crd that causes the dependency update step to be skipped for that release.

It defaults to "false" and is backward compatible (as it is not required).

some helm charts (istio being an example) add helm charts into the
"charts" folder directly and do not need "helm dep up" to be called. In
fact doing so will cause an error since the requirements have already
been fulfilled.  While you can disable this feature system wide it is
much more useful to allow individual helm releases to specify this
behavior.  this commit adds a 'skipDepUpdate' attribute to the
HelmRelease crd that causes the dependency update step to be skipped for
that release.
Copy link
Member

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @yinzara

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants