Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasource parameter for CloudWatch targets #442

Merged
merged 1 commit into from Dec 14, 2021

Conversation

romich
Copy link
Contributor

@romich romich commented Dec 7, 2021

What does this do?

Adds the ability to set datasource for CloudWatch targets, like in regular Target.

Why is it a good idea?

So that CloudWatch metrics could be used in panels with mixed datasources.

Copy link
Collaborator

@JamesGibo JamesGibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@JamesGibo JamesGibo merged commit a830ee0 into weaveworks:main Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants