Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to_json_data for Repeat class #453

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Conversation

achew22
Copy link
Contributor

@achew22 achew22 commented Jan 30, 2022

What does this do?

Previously it wasn't possible to make a Repeat class because it couldn't be turned into JSON

Why is it a good idea?

This makes it possible

Context

I think this is reasonably straight forward, but I'm happy to provide more context if you have questions.

Questions

No questions, thank you!

Copy link
Collaborator

@JamesGibo JamesGibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR not sure how that one got missed.
We should probably add a test for it but don't expect you to do that unless you wanted to?

@JamesGibo JamesGibo merged commit e7f0a9d into weaveworks:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants