Small cleanup #496
Merged
Small cleanup #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flagged by PyCharm. It looks like this snuck in with c665f21.
This appears to be an obvious typo (after PyCharm flagged `row_panel` as unused), but it looks like this is only used by `auto_panel_ids()`. I wasn't able to generate a difference in output before and after this change when adding 2 `SingleStat` panels to a `RowPanel`, and in turn adding that to the dashboard. The changed code definitely runs in this case, so IDK what is ultimately making the changes to the nested panels prior to this.
JamesGibo
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
These are small cleanups for lint type things flagged by PyCharm. I didn't bother with updating the changelog because AFAICT, it won't have user visible changes, but still is more correct.
Why is it a good idea?
Fewer lint type things get flagged in the IDE