Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add unit to tables and hide flag to es targets #604

Merged
merged 2 commits into from Jul 12, 2023
Merged

add unit to tables and hide flag to es targets #604

merged 2 commits into from Jul 12, 2023

Conversation

giloup933
Copy link
Contributor

What does this do?

  • Added a units parameter to core.Table.
  • Added a hide flag to ElasticsearchTarget.

Why is it a good idea?

  • Allows to display table entries as units of time/bytes/anything else.
  • ElasticsearchTarget is responsible for query results, so it is essential to be able to choose which ones to display with composite queries. For example if we want to display the ratio between two sums but not to see the sums.

@giloup933 giloup933 marked this pull request as ready for review June 17, 2023 05:07
JamesGibo
JamesGibo approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@JamesGibo JamesGibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@JamesGibo JamesGibo merged commit 2942349 into weaveworks:main Jul 12, 2023
5 checks passed
@giloup933 giloup933 deleted the g-new-params branch July 24, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesGibo JamesGibo JamesGibo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@giloup933 @JamesGibo