This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
specify the minimum version of make #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stealthybox
suggested changes
Sep 3, 2019
There was a problem hiding this comment.
Thanks for this -- I've tested it on my linux machine and the version gate works.
Would you please parameterize it like this? Cheers
MIN_MAKE_VERSION = 3.82
ifneq ($(MIN_MAKE_VERSION), $(firstword $(sort $(MAKE_VERSION) $(MIN_MAKE_VERSION))))
$(error this project requires make version $(MIN_MAKE_VERSION) or higher)
endif
Makefile
Outdated
| @@ -1,3 +1,7 @@ | |||
| ifneq (3.82, $(firstword $(sort $(MAKE_VERSION) 3.82))) | |||
There was a problem hiding this comment.
I'm just noting here that this is a lexical sort (ref)
This would eventually break with Make version 10, which is not a near-term concern.
There was a problem hiding this comment.
@silenceshell could you try to compute with bc or something like this:
silenceshell
force-pushed
the
check-make-version
branch
from
3339670
to
2ce03e1
Compare
|
@stealthybox @chanwit |
|
LGTM |
|
Thanks for the love on this patch @silenceshell |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #383
undefine(line 20) exists in GNU make 3.82 and higher, however on some osmakeis still 3.81 or even lower, for example macOS 10.14.We should check make version in Makefile.