Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

show runtime name when ignite version #405

Merged

Conversation

chanwit
Copy link
Member

@chanwit chanwit commented Sep 6, 2019

Add container runtime information to ignite version so that we could better help users troubleshoot.

Signed-off-by: Chanwit Kaewkasi chanwit@gmail.com

Signed-off-by: Chanwit Kaewkasi <chanwit@gmail.com>
@chanwit
Copy link
Member Author

chanwit commented Sep 6, 2019

kindly ping @stealthybox

@stealthybox
Copy link
Contributor

This is a bit silly at the moment, but it will make more sense when we have config(#315).
This could be improved with versions and socket locations.
For now, I think this is fine to merge -- thanks 👍

sudo bin/ignite version
Ignite version: version.Info{Major:"0", Minor:"6+", GitVersion:"v0.6.0-8+90af37d5b701d5-dirty", GitCommit:"90af37d5b701d5808036ccc7e1c257108e4fcdf0", GitTreeState:"dirty", BuildDate:"2019-09-06T15:56:32Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Firecracker version: v0.17.0
Runtime: containerd

sudo bin/ignite version --runtime docker
Ignite version: version.Info{Major:"0", Minor:"6+", GitVersion:"v0.6.0-8+90af37d5b701d5-dirty", GitCommit:"90af37d5b701d5808036ccc7e1c257108e4fcdf0", GitTreeState:"dirty", BuildDate:"2019-09-06T15:56:32Z", GoVersion:"go1.12.9", Compiler:"gc", Platform:"linux/amd64"}
Firecracker version: v0.17.0
Runtime: docker

@stealthybox stealthybox merged commit 8e6b372 into weaveworks:master Sep 6, 2019
@chanwit
Copy link
Member Author

chanwit commented Sep 6, 2019

Yeah I know that it's a bit silly. At least to get it to help users troubleshooting at the moment as some people not aware of the new default runtime setting to be containerd.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants