Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Followup to #526 Ubuntu 19+ tar symlink fix #577

Merged
merged 2 commits into from
Apr 10, 2020
Merged

Followup to #526 Ubuntu 19+ tar symlink fix #577

merged 2 commits into from
Apr 10, 2020

Conversation

stealthybox
Copy link
Contributor

Changes:

  • Use more portable flag "tar -h" to follow symlinks for GNU and Busybox tar.
    -h is not avialable on BSD tar
  • Restrict kernel image imports to /boot and /lib/modules

@luxas luxas self-assigned this Apr 10, 2020
@luxas luxas added this to the v0.7.0 milestone Apr 10, 2020
luxas
luxas approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! -h is the best option here IMO too, and as good as we can do at the moment to be cross-compatible. The lib/modules change is also good to not accidentally get cruft in the kernel image.

@luxas luxas merged commit f38704c into weaveworks:master Apr 10, 2020
@stealthybox stealthybox deleted the ubuntu19_tar_fix_followup_526 branch April 10, 2020 17:21
@darkowlzz darkowlzz mentioned this pull request Apr 19, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luxas luxas luxas approved these changes

@twelho twelho Awaiting requested review from twelho

Assignees

@luxas luxas

Labels
None yet
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stealthybox @luxas