This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
link-checking: Ignore /pkg/apis links, auto-generated docs #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stealthybox
suggested changes
Jun 22, 2020
| @@ -45,7 +45,7 @@ jobs: | |||
| id: lc2 | |||
| uses: peter-evans/link-checker@v1 | |||
| with: | |||
| args: -d site/ -r site/ -x "(github.com/weaveworks/ignite($|/issue|/pull|/releases|/commit/|/releases)|squidfunk.github.io|ignite.readthedocs.io)" | |||
| args: -d site/ -r site/ -x "(github.com/weaveworks/ignite($|/issue|/pull|/releases|/commit/|/releases|/tree/master/pkg/apis)|squidfunk.github.io|ignite.readthedocs.io)" | |||
There was a problem hiding this comment.
So should I close this PR? The theme update is not strictly necessary.
There was a problem hiding this comment.
@dholbach hi, we had a discussion about this in the weekly meeting. We agreed that it's useful to run the link checks on the master branch only and we should disable the checks on the PR.
Can you update this PR to keep the theme update and update the github workflow for check-links to not run on pull requests?
added 2 commits
July 31, 2020 09:52
- Update theme version as well. Closes: #618
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #618