Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Add ignite/v1alpha3 API #624

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Conversation

darkowlzz
Copy link
Contributor

  • Generate new API by copying v1alpha2 into v1alpha3 package directory and running make autogen.
  • Generated docs with make api-docs.

Related to #355

Generated by copying v1alpha2 into v1alpha3 and running `make autogen`.
Docs generated using `make api-docs`.
[doc.go](https://github.com/weaveworks/ignite/tree/master/pkg/apis/ignite/v1alpha3/doc.go)
[json.go](https://github.com/weaveworks/ignite/tree/master/pkg/apis/ignite/v1alpha3/json.go)
[register.go](https://github.com/weaveworks/ignite/tree/master/pkg/apis/ignite/v1alpha3/register.go)
[types.go](https://github.com/weaveworks/ignite/tree/master/pkg/apis/ignite/v1alpha3/types.go)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These links don't work at the moment, causing the link-checker to fail. Once this PR is merged, these links will become valid and the check should pass.

Copy link
Contributor

@twelho twelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 the link checker failures are indeed expected, it isn't aware of references to newly generated documentation linking to upcoming files in master.

@stealthybox stealthybox merged commit c53a6a4 into weaveworks:master Jun 22, 2020
@stealthybox stealthybox added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api/v1alpha3 kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants