This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Make runtime and network-plugin VM create flags #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darkowlzz
added
area/UX
stealthybox
reviewed
Aug 24, 2020
| --log-level loglevel Specify the loglevel for the program (default info) | ||
| --network-plugin plugin Network plugin to use. Available options are: [cni docker-bridge] (default cni) | ||
| -q, --quiet The quiet mode allows for machine-parsable output by printing only IDs | ||
| --runtime runtime Container runtime to use. Available options are: [docker containerd] (default containerd) |
There was a problem hiding this comment.
image import should probably have a runtime flag.
does not need to read any vm object.
flag is simply present to override ignite global config.
| --log-level loglevel Specify the loglevel for the program (default info) | ||
| --network-plugin plugin Network plugin to use. Available options are: [cni docker-bridge] (default cni) | ||
| -q, --quiet The quiet mode allows for machine-parsable output by printing only IDs | ||
| --runtime runtime Container runtime to use. Available options are: [docker containerd] (default containerd) |
|
commands like logs, exec, etc. will be modified to read from the VM object just like stop and start have already been. |
darkowlzz
force-pushed
the
non-global-providers
branch
from
3223c11
to
6129e27
Compare
Remove the global flags runtime and network-plugin to be VM create command flags. Update all the VM commands to read the runtime and network-plugin info from VM status. Make attach and logs command aware of VM providers. Add runtime flag to image and kernel import
Stopped VMs don't have the runtime and network info. Skip runtime operations when removing stopped VMs. To avoid losing VM info, during VM remove, perform CleanupVM() before deleting the VM manifest. Also, fixes patchStopped() function in ignite-spawn to patch correct VM status format.
darkowlzz
force-pushed
the
non-global-providers
branch
from
6129e27
to
b4d6a12
Compare
At VM stop, the runtime and network info are removed from the VM object. Attempting to start a VM fails due to unknown runtime and network. This adds runtime and network-plugin flag to VM start command to explicitly set the providers if needed. This also causes the VM to use the default providers when no providers are defined in the VM object. Update VM start docs.
- Start VM, check network, stop VM, start VM with the same providers and check network. - Start VM, check network, stop vm, start VM with different providers and check network access.
darkowlzz
force-pushed
the
non-global-providers
branch
from
443b41f
to
c77052e
Compare
|
Future generations will tell fond tales of the great and courageous traveler, @darkowlzz, and his inspiring, tenacious hunger for well-tested code. 🚢 lets merge this thang Bug related to a non-default profider VM being created, then separately started with defaulted flag values will be fixed for and tested in a follow-up by passing flagSet to the Start() call to inspect for Changed(). |
stealthybox
added
the
kind/enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up change to #651, which adds the runtime and
network-plugin info in the VM status.
runtimeandnetwork-pluginto be in VMcreatecommand.
run, stop, rm) to read theruntimeandnetwork-plugininfo from VM status.runtimeflag toimage import.patchStopped()status patch data in ignite-spawn as per the recent status changes.to VM start command.