Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Update installation instructions for Amazon Linux #671

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Update installation instructions for Amazon Linux #671

merged 1 commit into from
Aug 26, 2020

Conversation

Khalian
Copy link
Contributor

@Khalian Khalian commented Aug 24, 2020

Not everyone has a machine/instance lying around with kvm and virt assist. A lot of developers just leverage cloud providers to give them the necessary instances to work it.

This commit improves installation instructions for Amazon Linux 2


```bash
yum install -y e2fsprogs openssh-clients git
which containerd || sudo yum install -y docker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch -- this line should ideally just install containerd, not a full install of docker.

There doesn't appear to be a docker or containerd package on a default AmazonLinux 2 system.
*( I only checked with the amazonlinux:2 docker container's default yum repo setup though )

If you add the docker-ce repo directly from docker, it's possible to install the most up-to-date version of containerd from there, just like the CentOS example:

Suggested change
which containerd || sudo yum install -y docker
which containerd || ( yum-config-manager --add-repo https://download.docker.com/linux/centos/docker-ce.repo && yum install -y containerd.io )

Copy link
Contributor Author

@Khalian Khalian Aug 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was precisely the command I ran before and it did not work. Refer to #670.

Copy link
Contributor

@stealthybox stealthybox Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks! Sorry about that -- here's a better fix:

Suggested change
which containerd || sudo yum install -y docker
amazon-linux-extras enable docker
yum install -y containerd

I was able to verify this works within an AL2 docker container

Copy link
Contributor Author

@Khalian Khalian Aug 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So yes that works. And that would work fine with docker hub stuff. But when I try it with ECR I cant get it to work with just containerd : #673

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyways I still applied it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the install uniform for containerd.
Also appreciate the other bug you opened about registry auth.

I'm glad the docker runtime is helping you get around that 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea so about that, I think we need some instructions for runtime modes and more commands like ignite pull. I will be happy to write that down, but where should I put it?

Not everyone has a machine/instance lying around with kvm and virt assist. A lot of developers just leverage cloud providers to give them the necessary instances to work it.

This commit improves installation instructions for Amazon Linux 2
@stealthybox stealthybox merged commit cc76e20 into weaveworks:master Aug 26, 2020
@stealthybox stealthybox added the kind/documentation Categorizes issue or PR as related to documentation. label Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation/improvement Improve something in the docs kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants